Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test to use second num_semantic_classes input. #644

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update test to use second num_semantic_classes input. #644

merged 1 commit into from
Jan 13, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jan 11, 2023

What

Closes gh-643. If there's a reason not to use the nsc2 input, then alternatively we can delete that var.

Why

See gh-643 for context.

msschwartz21
msschwartz21 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rossbar rossbar added the chore Maintenance label Jan 13, 2023
@rossbar rossbar merged commit 0862f4d into vanvalenlab:master Jan 13, 2023
@rossbar rossbar deleted the fix-gh-643 branch January 13, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msschwartz21 msschwartz21 msschwartz21 approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seems test case may be using the wrong model?
2 participants
@rossbar @msschwartz21